Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'



Already fixed in 47323.  Please write patches against latest master.
Thanks!

Arseny Maslennikov wrote on Sat, Feb 27, 2021 at 14:55:01 +0300:
> The "tmp" array is being filled up with specstrings for _arguments in
> all three cases, but is unused afterwards. Thus non-option arguments
> after e. g. `rpmbuild -ba' are not being offered as completion matches.
> ---
>  Completion/Redhat/Command/_rpm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
> index e3469245f..6e4a1e6a1 100644
> --- a/Completion/Redhat/Command/_rpm
> +++ b/Completion/Redhat/Command/_rpm
> @@ -283,6 +283,7 @@ _rpm () {
>      build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
>      build_?)
>        _arguments -s -C $buildopts $commonopts $pathopts \
> +          "${tmp[@]}"
>        ;;
>      checksig)
>        _arguments -s -C \!-K \
> -- 
> 2.29.2
> 
> 




Messages sorted by: Reverse Date, Date, Thread, Author