Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'
- X-seq: zsh-workers 48125
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Arseny Maslennikov <arseny@xxxxxxxxxxxx>
- Cc: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?'
- Date: Sat, 27 Feb 2021 13:24:06 +0000
- Archived-at: <https://zsh.org/workers/48125>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-02/20210227132406.GB9308%40tarpaulin.shahaf.local2>
- In-reply-to: <20210227115501.332503-1-arseny@altlinux.org>
- List-id: <zsh-workers.zsh.org>
- References: <20210227115501.332503-1-arseny@altlinux.org>
Already fixed in 47323. Please write patches against latest master.
Thanks!
Arseny Maslennikov wrote on Sat, Feb 27, 2021 at 14:55:01 +0300:
> The "tmp" array is being filled up with specstrings for _arguments in
> all three cases, but is unused afterwards. Thus non-option arguments
> after e. g. `rpmbuild -ba' are not being offered as completion matches.
> ---
> Completion/Redhat/Command/_rpm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm
> index e3469245f..6e4a1e6a1 100644
> --- a/Completion/Redhat/Command/_rpm
> +++ b/Completion/Redhat/Command/_rpm
> @@ -283,6 +283,7 @@ _rpm () {
> build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
> build_?)
> _arguments -s -C $buildopts $commonopts $pathopts \
> + "${tmp[@]}"
> ;;
> checksig)
> _arguments -s -C \!-K \
> --
> 2.29.2
>
>
Messages sorted by:
Reverse Date,
Date,
Thread,
Author