Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Bug + patch: `zstyle ':completion:*' menu select=long-list` fails to start menu selection



Marlon Richert wrote on Thu, Mar 04, 2021 at 10:56:06 +0200:
> Test case:
> ```
> exec zsh -f
> LISTMAX=0
> setopt menucomplete
> autoload -Uz compinit; compinit
> zstyle ':completion:*' menu select=long-list
> zsh -^D
> ```

Thanks.  Haven't reviewed the patch, but assuming it's correct, it'd be
great to have this test upgraded to a proper regression test; see
Test/README in the source tree.

Cheers,

Daniel


> Patch:
> ```
> diff --git Completion/Base/Core/_main_complete
> Completion/Base/Core/_main_complete
> index 663f755..9d90b0f 100644
> --- Completion/Base/Core/_main_complete
> +++ Completion/Base/Core/_main_complete
> @@ -244,7 +244,7 @@ if [[ $compstate[old_list] = keep || nm -gt 1 ]]; then
> 
>    _menu_style=( "$_menu_style[@]" "$_def_menu_style[@]" )
> 
> -  if [[ "$compstate[list]" = *list && tmp -gt LINES &&
> +  if [[ "$compstate[list]" = *list(| *) && tmp -gt LINES &&
>          ( -n "$_menu_style[(r)select=long-list]" ||
>            -n "$_menu_style[(r)(yes|true|on|1)=long-list]" ) ]]; then
>      compstate[insert]=menu
> ```
> 




Messages sorted by: Reverse Date, Date, Thread, Author