Re: [PATCH] Fix [:IDENT:] vs posixidentifiers

[Stephane Chazelas <stephane@xxxxxxxxxxxx>]

Ping again. Note that it's pretty straighforward, and I don't
expect anyone would object to it.

I also have a (much more involved and arguable) "limit" patch
from last year which might be on someone's review queue.

Maybe it would help to publish review queues on zsh.org (may as
flat list of workers/1234 lines for each reviewer), so patch
submitters can know whether or not the patch is being considered
but reviewer are overwhelmed or it simply fell through the cracks.

(in any case, I'm in no particular hurry for that (minor) bug to
be fixed).

Cheers,
Stephane

2021-02-07 15:50:13 +0000, Stephane Chazelas:
> Ping. Anybody objecting to this?
> 
> 2020-12-17 15:08:44 +0000, Stephane Chazelas:
> > $ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no
> > no
> > $ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes
> > yes
> > 
> > That should be the other way round.
> > 
> > 
> > From: Stephane Chazelas <stephane@xxxxxxxxxxxx>
> > Date: Thu, 17 Dec 2020 14:49:50 +0000
> > Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers
> > 
> > wcsitype(c, IIDENT) should return false for non-ASCII characters
> > when the POSIX_IDENTIFIERS option is on, not the other way round.
> > ---
> >  Src/utils.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Src/utils.c b/Src/utils.c
> > index 5151b89a8..2a8d677a7 100644
> > --- a/Src/utils.c
> > +++ b/Src/utils.c
> > @@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype)
> >      } else {
> >  	switch (itype) {
> >  	case IIDENT:
> > -	    if (!isset(POSIXIDENTIFIERS))
> > +	    if (isset(POSIXIDENTIFIERS))
> >  		return 0;
> >  	    return iswalnum(c);
> >  
> > -- 
> > 2.29.2
> > 
>