Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Fix zstyle option completion
- X-seq: zsh-workers 48320
- From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
- To: Lawrence Velázquez <vq@xxxxxxxxx>, dana <dana@xxxxxxx>
- Cc: zsh-workers@xxxxxxx
- Subject: Re: [PATCH] Fix zstyle option completion
- Date: Mon, 29 Mar 2021 13:46:12 +0000
- Archived-at: <https://zsh.org/workers/48320>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-03/20210329134612.GR18178%40tarpaulin.shahaf.local2>
- In-reply-to: <cf90c2f0-f39e-45de-aae7-ade1bc53b4a3@www.fastmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <D5C6BE91-013B-476D-BF33-505C72CF6FAC@dana.is> <20201213173119.GA6254@tarpaulin.shahaf.local2> <2D922DB3-2D14-4F78-B99E-7F0D7C5D6F63@dana.is> <cf90c2f0-f39e-45de-aae7-ade1bc53b4a3@www.fastmail.com>
Lawrence Velázquez wrote on Sat, Mar 27, 2021 at 16:08:12 -0400:
> On Mon, Dec 14, 2020, at 4:55 AM, dana wrote:
> > On 13 Dec 2020, at 11:31, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > > Could you clarify the precise LBUFFER/RBUFFER values that "won't
> > > complete"?
> >
> > For example, when i do:
> >
> > # LBUFFER='zstyle -'
> > # RBUFFER=' foo bar'
> > % zstyle -<TAB> foo bar
> >
> > ... it tries (unsuccessfully) to complete argument-1 instead of showing me
> > options.
> >
> > On 13 Dec 2020, at 11:31, Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > > As written, I think the patch will cause «zstyle -g foo bar baz <TAB>»
> > > to offer completions, whereas currently it correctly completes nothing.
> >
> > I don't think it should. All the options are exclusive with each other, so
> > that takes care of that already, and the -A '-*' should handle cases like
> > `zstyle foo bar <TAB>`. It gives me 'no more arguments' when i test your
> > example with my change. But i might not fully understand what you mean
>
> Anything further on this?
Pushed. Also fixed the X-Seq's in ChangeLog while I was at it. Thank
you both!
Messages sorted by:
Reverse Date,
Date,
Thread,
Author