Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: _perl_modules assumes it's called by perl

X-seq: zsh-workers 48325
From: "Daniel Shahaf" <d.s@xxxxxxxxxxxxxxxxxx>
To: "Zsh hackers list" <zsh-workers@xxxxxxx>
Subject: Re: PATCH: _perl_modules assumes it's called by perl
Date: Mon, 29 Mar 2021 15:28:52 +0000
Archived-at: <https://zsh.org/workers/48325>
Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-03/728536af-2738-4cdb-bc56-f64b2ab8be30%40www.fastmail.com>
In-reply-to: <CAH+w=7ap1534966=vrAW1hFmwY=4LWr6dXoM72oNFPzH0QeGPA@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20210329150644.GA30806@tarpaulin.shahaf.local2> <CAH+w=7ap1534966=vrAW1hFmwY=4LWr6dXoM72oNFPzH0QeGPA@mail.gmail.com>

Bart Schaefer wrote on Mon, 29 Mar 2021 15:16 +00:00:
> On Mon, Mar 29, 2021 at 8:07 AM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> >
> \> +  if [[ $service == (perl|perldoc) ]]; then
> > +    perl=${${(Q)words[1]}%doc}
> 
> This still needs to be checked with "whence perl" to make [[ -n $perl
> ]] have the (intended but messed up) previous semantics.
> 
> I otherwise agree with the intent of the patch.

Thanks for the review.  So, just add «whence -- $perl >/dev/null || perl=» after the quoted assignment?

Follow-Ups:
- Re: PATCH: _perl_modules assumes it's called by perl
  - From: Daniel Shahaf

References:
- PATCH: _perl_modules assumes it's called by perl
  - From: Daniel Shahaf
- Re: PATCH: _perl_modules assumes it's called by perl
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author