Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Bug report: Completion for dynamically named dirs fails when $SUFFIX is not empty



> On 31 March 2021 at 09:37 Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
> On Wed, Mar 31, 2021 at 11:29 AM Marlon Richert
> <marlon.richert@xxxxxxxxx> wrote:
> >
> > On Wed, Mar 31, 2021 at 11:25 AM Peter Stephenson
> > <p.w.stephenson@xxxxxxxxxxxx> wrote:
> > > > On 31 March 2021 at 09:10 Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
> > > > Could someone please review Peter's patch, below?
> > >
> > > This change is already in.
> >
> > Really? I don't see it in Src/Zle/zle_main.c on the master branch.
> 
> You are right that the other changes are in. Sorry, I only checked
> `git log -L 1060,1100:Src/Zle/zle_main.c` and when that failed to show
> any changes, I assumed that the whole patch had not been applied yet.
> 
> However, why apply only the changes in the other files and not the one
> in Src/Zle/zle_main.c ? Is that intentional or an oversight?

Apologies, that was intentional because I realised the diff I sent included
some old stuff which actually wasn't needed. The zle_main.c chunk in the
patch is irrelevant to the fix.

pws




Messages sorted by: Reverse Date, Date, Thread, Author