Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: Y01 Test Failure on Arch



Vin Shelton wrote on Sun, 04 Apr 2021 14:00 +00:00:
> 
> 
> On Sun, Apr 4, 2021 at 12:05 AM Jun. T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> > 
> > > 2021/04/03 20:32, Vin Shelton <acs@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > 
> > > Ping.  The failure still occurs.
> > 
> > Do you mean it still fails with my patch?
>  
> No, I mean your patch hasn't been applied.  ISTR you also expressed 
> concerns that your patch wasn't certainly the right way to go.  Also, 
> *why* was the test change necessary in the first place?  
> Philosophically, I think the tests should reflect the current behavior 
> of the shell - one doesn't change the test unless one understands why.

Vin, thanks for the nudges and for the review.

Marlon, the failure is due to workers/48214, which is yours.  Thoughts?

Cheers,

Daniel




Messages sorted by: Reverse Date, Date, Thread, Author