Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Y01 Test Failure on Arch
- X-seq: zsh-workers 48393
- From: "Daniel Shahaf" <d.s@xxxxxxxxxxxxxxxxxx>
- To: "Vin Shelton" <acs@xxxxxxxxxxxxxxxxxxxx>, "Marlon Richert" <marlon.richert@xxxxxxxxx>
- Cc: "Zsh Hackers' List" <zsh-workers@xxxxxxx>, "Jun T" <takimoto-j@xxxxxxxxxxxxxxxxx>
- Subject: Re: Y01 Test Failure on Arch
- Date: Sun, 04 Apr 2021 17:02:02 +0000
- Archived-at: <https://zsh.org/zsh-workers/48393>
- Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-04/bf2c30eb-1a37-4c53-a019-a6fceb6625d4%40www.fastmail.com>
- In-reply-to: <CACeGjnUdhkOfFysohkDxZP6=-dBwv_Rhe0Y=fJF62UEWM5C4OQ@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CACeGjnW0YAGgU7MwHA-qXcb1QcnvrYrks0zh0+pdhVwMgmyxNg@mail.gmail.com> <A36DEE01-E038-4F5C-91E6-1B2972E3487F@kba.biglobe.ne.jp> <CACeGjnVQamQM0r4d45CAHTOq=vERpQwiDUV0_SaKm_Ey_D+bPg@mail.gmail.com> <F939B540-AC45-4DD2-9350-DDAE4FB349A2@kba.biglobe.ne.jp> <CACeGjnUdhkOfFysohkDxZP6=-dBwv_Rhe0Y=fJF62UEWM5C4OQ@mail.gmail.com>
Vin Shelton wrote on Sun, 04 Apr 2021 14:00 +00:00:
>
>
> On Sun, Apr 4, 2021 at 12:05 AM Jun. T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
> >
> > > 2021/04/03 20:32, Vin Shelton <acs@xxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > Ping. The failure still occurs.
> >
> > Do you mean it still fails with my patch?
>
> No, I mean your patch hasn't been applied. ISTR you also expressed
> concerns that your patch wasn't certainly the right way to go. Also,
> *why* was the test change necessary in the first place?
> Philosophically, I think the tests should reflect the current behavior
> of the shell - one doesn't change the test unless one understands why.
Vin, thanks for the nudges and for the review.
Marlon, the failure is due to workers/48214, which is yours. Thoughts?
Cheers,
Daniel
Messages sorted by:
Reverse Date,
Date,
Thread,
Author