Re: Y01 Test Failure on Arch

X-seq: zsh-workers 48398

From: Vin Shelton <acs@xxxxxxxxxxxxxxxxxxxx>

To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>

Cc: "Jun. T" <takimoto-j@xxxxxxxxxxxxxxxxx>, "Zsh Hackers' List" <zsh-workers@xxxxxxx>

Subject: Re: Y01 Test Failure on Arch

Date: Sun, 4 Apr 2021 20:39:14 -0400

Archived-at: <https://zsh.org/workers/48398>

Archived-at: <http://www.zsh.org/sympa/arcsearch_id/zsh-workers/2021-04/CACeGjnXLVJ3-Seu9j8o%2B8DdLOdzPrU%3DyuduwgUmoJOyQVYetxQ%40mail.gmail.com>

In-reply-to: <CAH+w=7a7Pm4JUPLUYvDnVACfbpZTOB+RXF7281CNasRH9iSbKw@mail.gmail.com>

List-id: <zsh-workers.zsh.org>

References: <CACeGjnW0YAGgU7MwHA-qXcb1QcnvrYrks0zh0+pdhVwMgmyxNg@mail.gmail.com> <A36DEE01-E038-4F5C-91E6-1B2972E3487F@kba.biglobe.ne.jp> <CACeGjnVQamQM0r4d45CAHTOq=vERpQwiDUV0_SaKm_Ey_D+bPg@mail.gmail.com> <F939B540-AC45-4DD2-9350-DDAE4FB349A2@kba.biglobe.ne.jp> <CACeGjnUdhkOfFysohkDxZP6=-dBwv_Rhe0Y=fJF62UEWM5C4OQ@mail.gmail.com> <CAH+w=7a7Pm4JUPLUYvDnVACfbpZTOB+RXF7281CNasRH9iSbKw@mail.gmail.com>

So it sounds like Jun's fix is the right one?

- Vin

On Sun, Apr 4, 2021 at 2:27 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:

(I'm on "vacation" this week so won't have as much feedback as I have lately.)

On Sun, Apr 4, 2021 at 7:01 AM Vin Shelton <acs@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Also, why was the test change necessary in the first place?

The test was not checking the correct thing. expand-or-complete first
invokes the built-in expand-word and then falls back on completion,
but the patch updated the _expand completer (which was never reached
after expand-word produced a result).

Reverse Date

Date

Thread

Author