Re: [PATCH v4] vcs_info: choose backend by basedir

[Lawrence Velázquez <larryv@xxxxxxx>]

On Mon, Mar 29, 2021, at 12:56 PM, Daniel Shahaf wrote:
> Let me first summarize the previous threads:
> 
> - The current default is that backends are used in order of the «enable»
>   style: first detected, wins.
> 
> - Frank prefers this remain the default.  (workers/47488, workers/47509)
> 
> - Aleksandr implemented a mode in which the backend whose worktree root
>   directory is closest to $PWD would be used.
> 
> - Bart's use-case (workers/44931) wouldn't be served by choosing the
>   "deepest" worktree but by choosing whichever one has local mods.
>   (workers/47490)
> 
> - It was proposed to address Bart's use-case by calling vcs_info twice
>   with different user-context strings and corresponding zstyle settings.
> 
> - Oliver proposed some independent improvements in workers/47492.
> 
> If any of that is inaccurate, speak up.  The named people are Bcc'd.
> 
> The patch being replied to contained some git- and cvs-specific changes
> which have been committed.  Aleksandr expressed concerns about those in
> workers/44929, but as far as I can see, the part that has been committed
> is a no-op, other than the fact that vcs_comm[basedir] will be populated
> earlier.
> 
> So, first things first: Does implementing a "choose the VCS whose root
> is deepest" mode that's off by default sound like a reasonable way
> forward?  Any concerns with that?  Any concerns with the algorithm
> described in Aleksandr's log message (just the log message,
> independently of the unidiff)?
> 
> Below a couple of review points on my account.  Not a full review; just
> what I spotted from reading the diff.

bump

vq