Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [RFC][PATCH] `newuser` prompt theme



Marlon wrote on Fri, Apr 16, 2021 at 19:04:06 +0300:
> Question for Daniel: If you’re going to add sysexits(3) to PRINT_EXIT_VALUE anyway (workers/48564), should I just get rid of prompt_vcs_precmd()? Or do you think it still adds value?

IMO keep that function.  We can always simplify that function if and when
sysexits(3) PRINT_EXIT_VALUE support is added.

You seem to have sent the patch three times, nested.  Which one should
be reviewed?

> From 172e2a886fcb499fd1f0712836721366dc66cb74 Mon Sep 17 00:00:00 2001
> From: Marlon Richert <marlon.richert@xxxxxxxxx>
> Date: Thu, 15 Apr 2021 23:28:56 +0300
> Subject: [PATCH] Add customizable `vcs` prompt theme
> 
> ---
>  0001-Add-customizable-vcs-prompt-theme.patch | 499 +++++++++++++++++++
>  Functions/Prompts/prompt_vcs_setup           | 227 +++++++++
> 
> +++ b/0001-Add-customizable-vcs-prompt-theme.patch
> @@ -0,0 +1,499 @@
> +From 1d557059a1ae35be86f17832526198abde8d949d Mon Sep 17 00:00:00 2001
> +From: Marlon Richert <marlon.richert@xxxxxxxxx>
> +Date: Thu, 15 Apr 2021 23:28:56 +0300
> +Subject: [PATCH] Add customizable `vcs` prompt theme
> +
> +---
> + 0001-Add-customizable-vcs-prompt-theme.txt | 245 +++++++++++++++++++++
> + Functions/Prompts/prompt_vcs_setup         | 227 +++++++++++++++++++
> +
> +diff --git a/0001-Add-customizable-vcs-prompt-theme.txt b/0001-Add-customizable-vcs-prompt-theme.txt
> +new file mode 100644
> +index 000000000..980f4a317
> +--- /dev/null
> ++++ b/0001-Add-customizable-vcs-prompt-theme.txt
> +@@ -0,0 +1,245 @@
> ++From 1d34a81c3b09228deaf9de599e42611ec4fe21dd Mon Sep 17 00:00:00 2001
> ++From: Marlon Richert <marlon.richert@xxxxxxxxx>
> ++Date: Thu, 15 Apr 2021 23:28:56 +0300
> ++Subject: [PATCH] Add customizable `vcs` prompt theme
> ++
> +++++ b/Functions/Prompts/prompt_vcs_setup
> ++@@ -0,0 +1,226 @@
> ++++ b/Functions/Prompts/prompt_vcs_setup
> +@@ -0,0 +1,227 @@
> +++ b/Functions/Prompts/prompt_vcs_setup
> @@ -0,0 +1,227 @@




Messages sorted by: Reverse Date, Date, Thread, Author