Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function)

X-seq: zsh-workers 48646
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function)
Date: Wed, 21 Apr 2021 13:40:20 -0700
Archived-at: <https://zsh.org/workers/48646>
In-reply-to: <AEC92FEA-6216-4952-818E-9DC7C584698A@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <95CDA630-4EE5-4003-8D9C-CCCB9A47F109@gmail.com> <CAH+w=7bpkYktd4UN5DtUS45MMNdWYr7c-OG7DHOX21QXG4LMUA@mail.gmail.com> <4D587C0C-EB5F-4A58-A0AE-D45E43F432CD@gmail.com> <CAH+w=7bQLq43JChP7PmaqT_wHMwgs4Nk_-0grrtQXEhQJcfrbA@mail.gmail.com> <CAH+w=7ZCzG-BGZuU-rLoZJX=3zcA74NK+TNVDP-CWF-9b-BfrA@mail.gmail.com> <AEC92FEA-6216-4952-818E-9DC7C584698A@gmail.com>

On Wed, Apr 21, 2021 at 4:37 AM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>
> Thank you both (Bart & Daniel) for your input. I added better safeguards against the non-PS1 cases, rewrote the function to be more generic and added comments. New patch attached.

I remain confused about why .push-line-or-edit rather than .push-input
?   I think you're making this more complicated than necessary.

References:
- [RFC][PATCH] Add change-directory() widget function
  - From: Marlon Richert
- Re: [RFC][PATCH] Add change-directory() widget function
  - From: Bart Schaefer
- Re: [RFC][PATCH] Add change-directory() widget function
  - From: Marlon Richert
- Re: [RFC][PATCH] Add change-directory() widget function
  - From: Bart Schaefer
- Re: [RFC][PATCH] Add change-directory() widget function
  - From: Bart Schaefer
- [PATCH] Add execute-command() widget function (was Re: [RFC][PATCH] Add change-directory() widget function)
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author