Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v2] regexp-replace and ^, word boundary or look-behind operators

X-seq: zsh-workers 48763
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH v2] regexp-replace and ^, word boundary or look-behind operators
Date: Fri, 30 Apr 2021 16:13:34 -0700
Archived-at: <https://zsh.org/workers/48763>
In-reply-to: <20210430061117.buyhdhky5crqjrf2@chazelas.org>
List-id: <zsh-workers.zsh.org>
References: <20191216211013.6opkv5sy4wvp3yn2@chaz.gmail.com> <20191216212706.i3xvf6hn5h3jwkjh@chaz.gmail.com> <20191217073846.4usg2hnsk66bhqvl@chaz.gmail.com> <20191217111113.z242f4g6sx7xdwru@chaz.gmail.com> <2ea6feb3-a686-4d83-ab27-6a582424487c@www.fastmail.com> <20200101140343.qwfx2xaojumuds3d@chaz.gmail.com> <20210430061117.buyhdhky5crqjrf2@chazelas.org>

On Thu, Apr 29, 2021 at 11:12 PM Stephane Chazelas
<stephane.chazelas@xxxxxxxxx> wrote:
>
> ping.

I went back and looked at the patch again.

Tangential question:  "pgrep" commonly refers to grepping the process
list, and is linked to "pkill".  I know "zpgrep" precedes this patch,
but I'm wondering if we should rename it.

More directly about regexp-replace:

If $argv[4,-1] are going to be ignored/discarded, perhaps there should
be a warning?  (Another thing that predates the patch, I know)

What do you think about replacing the final eval with typeset -g, as
mentioned in workers/48760 ?

I don't see any reason to doubt the accuracy of the implementation, so
except possibly for that last question I think the patch could be
applied and the other two items addressed elsewhere.  Thoughts?

Follow-Ups:
- [PATCH v3] regexp-replace and ^, word boundary or look-behind operators (and more).
  - From: Stephane Chazelas

References:
- Re: [PATCH v2] regexp-replace and ^, word boundary or look-behind operators
  - From: Stephane Chazelas

Messages sorted by: Reverse Date, Date, Thread, Author