Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: I've caught up on pending commits; how about you?
On Sat, May 15, 2021 at 4:22 PM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>
> And there's the ctags patch that has been committed with some review
> points outstanding. A glance at _ctags in master shows that external
> command output is passed to _values' «spec» arguments unsanitized.
I don't have access to the ctags variant that supports
--list-languages, but I presume you're referring to
_values -s , languages $languages
The value of $languages comes from _ctags_languages which produces
only strings matching the sed pattern
[A-Za-z][A-Za-z0-9#_+]*
What additional sanitation do you feel is needed? This was done in
response to your previous criticism of this point.
As far as I can tell the only un-address review points are from
Oliver's workers/48296
Messages sorted by:
Reverse Date,
Date,
Thread,
Author