Re: [PATCH] Improve extra-verbose completion of array params

[Oliver Kiddle <opk@xxxxxxx>]

On 27 Apr, Marlon Richert wrote:
> This patch improves the extra-verbose completion display strings for
> arrays and associative arrays.
> -    verbose=(
> -        ${described[@]:/(#m)*/"${MATCH}:${(@q+)${(Pkv@q+)MATCH}//\\/\\\\}"} )
> +    verbose=( ${${${(f@)"$( typeset -m $described )"}/=/:}[@]//'\'/'\\'} )

Why the use of -m here? Is that to avoid it creating variables (which
may not matter especially in the subshell). Do we need to be concerned
about the possibility of glob characters appearing there and producing
more output than expected?

Apart from my puzzlement over that the patch essentially looks fine.
I did notice some issues with _describe being messed up with compadd
options in later use of the new feature (without this extra patch) which
I intended to come back and take a look at.

>  (( compstate[nmatches] > nm ))
> -return 0

That's certainly correct and I ought to have caught it before committing.

Oliver