Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: Feature request: italic style in region_highlight
- X-seq: zsh-workers 48923
- From: Oliver Kiddle <opk@xxxxxxx>
- To: Marlon Richert <marlon.richert@xxxxxxxxx>
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: Feature request: italic style in region_highlight
- Date: Tue, 25 May 2021 18:38:59 +0200
- Archived-at: <https://zsh.org/workers/48923>
- In-reply-to: <CAHLkEDs5xV9f-iv6WAmjnYp2FP6wZm5AL_0+FwmJwWwAJjYrZw@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAKc7PVC5=SZfY8ExEZ9W2GWa=rYTu545hz9RrE9Uae=MadynSg@mail.gmail.com> <CAN=4vMpBOD5XJOgjiOWYUJV4QaV2Fn9+PkgTCTMtArJ4GxJA8w@mail.gmail.com> <CAH+w=7atVBgGEQ0M919mKLzqrcJBHALgLcuKFQmyRYCad00JdQ@mail.gmail.com> <CAN=4vMrtbUFpyLLdvKZtGLMss4RT5qKUBU6EoPr3y-3JotEy5w@mail.gmail.com> <CAH+w=7a452bDNEywy_btmB0B=2YrMKvQqmYMyzNnbTMZi2p9AQ@mail.gmail.com> <40813-1577992732.270919@2Jfy.SNk-.4lUU> <CAN=4vMo__T7nLxcUzc7qvQQH9QC5UC+Ofjq7y8XEFfgEBC19DQ@mail.gmail.com> <CAH+w=7YwxZtvZ5vetnvDVLMU8Q8=cg65hr37u6Cu66TiCGJcCQ@mail.gmail.com> <20200103202807.cxocci634aksqwot@tarpaulin.shahaf.local2> <CAHLkEDs5xV9f-iv6WAmjnYp2FP6wZm5AL_0+FwmJwWwAJjYrZw@mail.gmail.com>
On 20 May, Marlon Richert wrote:
> Did this discussion and the one in workers/47491 ever result in
> anything? Is it still on the table?
I did apply patch 47510 which corresponds to possibility (1) from
workers/47491. That does free the necessary two bits for italic to be
possible. I was inclined to give that some time before reusing the
bits in case it needs to be reverted.
I still think possibility (2) from 47491 is worth pursuing, mainly
because the associated refactoring would likely simplify a good chunk
of code. There's probably demand for supporting further attributes. But
I'm not sure whether there are any I'd have much use for. Faint and
dim don't seem to be supported in any of my terminals and are possibly
often only equivalent to a different colour. <blink> in HTML was derided
for a good reason. reverse as distinct from standout should probably be
supported.
Actually adding the support for just italic should now be relatively
straightforward because it is mostly copy and paste from existing
attributes. %A{italic} rather than %O would be slightly more effort but
is, I think, nicer. If we do end up having to revert 47510, possibility
(3) is at least definitely possible as a last resort even though it'd
make the code uglier.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author