Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line

X-seq: zsh-workers 48949
From: Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>
To: Akinori MUSHA <knu@xxxxxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line
Date: Sat, 29 May 2021 11:41:08 +0000
Archived-at: <https://zsh.org/workers/48949>
In-reply-to: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org>
List-id: <zsh-workers.zsh.org>
References: <92d2b09c-9559-7085-a521-29714e38f02c@iDaemons.org>

Akinori MUSHA wrote on Fri, May 28, 2021 at 22:35:08 +0900:
> This patch makes the name of a temporary file to have a .zsh suffix so
> that the invoked editor will know it's a zsh script.  The .zsh suffix is
> commonly recognized by editors like Emacs, Vim and VS Code.

Thanks for the patch.

Vim already sets the filetype correctly in this case, via the «au
BufNewFile,BufRead zsh*,zlog* call s:StarSetf('zsh')» pattern match in
$VIMRTUNETIME/filetype.vim.  However, I suspect that pattern produces
some false negatives too (e.g., it also matches in cases such as «vim
=(ls)»), so I think this change would be an improvement even for Vim users.

> It's so much easier to edit a command line in a proper editing mode than in
> a plain text mode.

Agreed.  The patch looks good to me, but I haven't time to review or
test it properly, so I'll defer to others on that.

Thanks,

Daniel

Follow-Ups:
- Re: [PATCH] Set TMPSUFFIX=.zsh in edit-command-line
  - From: Bart Schaefer

References:
- [PATCH] Set TMPSUFFIX=.zsh in edit-command-line
  - From: Akinori MUSHA

Messages sorted by: Reverse Date, Date, Thread, Author