Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix a logic bug in _zle

X-seq: zsh-workers 48973
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Fix a logic bug in _zle
Date: Mon, 31 May 2021 14:56:34 -0700
Archived-at: <https://zsh.org/workers/48973>
In-reply-to: <CAHLkEDsedEs-O-6OLaFPdPOGM33n4A9px2sqCtm_rEFA49qmsw@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDu=pKddp9wtU8C7++ZqNdq3ajBmfjNnB1TN0pMaBn-QJQ@mail.gmail.com> <CAH+w=7YHiEnxSNh65Z4K+Fuz+x_KyZZycZnUG1ArfhF6hQirmg@mail.gmail.com> <CAHLkEDsedEs-O-6OLaFPdPOGM33n4A9px2sqCtm_rEFA49qmsw@mail.gmail.com>

On Mon, May 31, 2021 at 10:49 AM Marlon Richert
<marlon.richert@xxxxxxxxx> wrote:
>
> On Mon, May 31, 2021 at 8:08 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > For purposes of the commit log, we should be told what this means in
> > terms of a behavior change.
>
> Is it good enough this way?

Better, but you could have just said that in the email text rather
than embed it in the patch file.

However, I can't figure out when $state[1] == widget-function is ever
true.  Did you possibly mean widget-or-function ?  If not, can you
give an example?

Follow-Ups:
- Re: [PATCH] Fix a logic bug in _zle
  - From: Marlon Richert

References:
- [PATCH] Fix a logic bug in _zle
  - From: Marlon Richert
- Re: [PATCH] Fix a logic bug in _zle
  - From: Bart Schaefer
- Re: [PATCH] Fix a logic bug in _zle
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author