Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Increase $COLUMNS when generating long option completions

X-seq: zsh-workers 49245
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Lawrence Velázquez <larryv@xxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Increase $COLUMNS when generating long option completions
Date: Wed, 4 Aug 2021 23:24:38 -0700
Archived-at: <https://zsh.org/workers/49245>
In-reply-to: <CAHLkEDsieRtSrdYPwCOUDGZRprukkBwuGwJ51SjLZExDVZ3Y4g@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDsYUVFXEyzUG2m1O7PeXPM0J4VnscL-yM-fv2Kbj3h85A@mail.gmail.com> <CB6936F6-1D97-4CE0-ACE2-71785A163450@zsh.org> <CAHLkEDsieRtSrdYPwCOUDGZRprukkBwuGwJ51SjLZExDVZ3Y4g@mail.gmail.com>

On Wed, Aug 4, 2021 at 11:20 PM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>
> I don't think this all changes anything about the patch, though?

On Tue, Aug 3, 2021 at 8:48 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> The next question would be, is _arguments the only place this is
> useful?  Or would it be better  if _call_program always did so? E.g.
>   local -x COLUMNS

If the answer to that is to leave it in _arguments, then I think
COLUMNS=$COLUMNS is preferable to COLUMNS=999

Follow-Ups:
- Re: [PATCH] Increase $COLUMNS when generating long option completions
  - From: Marlon Richert

References:
- Re: [PATCH] Increase $COLUMNS when generating long option completions
  - From: Marlon Richert
- Re: [PATCH] Increase $COLUMNS when generating long option completions
  - From: Lawrence Velázquez
- Re: [PATCH] Increase $COLUMNS when generating long option completions
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author