Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] fix completion of parameter names for ${<TAB> and ${(a)<TAB>

X-seq: zsh-workers 49541
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: "Jun. T" <takimoto-j@xxxxxxxxxxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] fix completion of parameter names for ${<TAB> and ${(a)<TAB>
Date: Sun, 31 Oct 2021 21:24:43 -0700
Archived-at: <https://zsh.org/workers/49541>
In-reply-to: <DCDED98D-8CF9-4DD3-8CAD-2E82F8E1FBD4@kba.biglobe.ne.jp>
List-id: <zsh-workers.zsh.org>
References: <DCDED98D-8CF9-4DD3-8CAD-2E82F8E1FBD4@kba.biglobe.ne.jp>

On Fri, Oct 29, 2021 at 11:47 PM Jun. T <takimoto-j@xxxxxxxxxxxxxxxxx> wrote:
>
> ${<TAB> works if '>=' is replaced by '>' at line 1192 of compcore.c
> (I think this is a simple off-by-one error).

That makes sense ... if the previous skipparens test was for <= this
on should be >.

> But ${(a)<TAB> still
> doesn't work. In the patch below I removed the lines 1203-1209
> (and the use of the variable 'tb' that is now redundant) to fix
> this problem.

Thanks.  I think those lines were intended as an optimization but I
probably tested it only with completeinword and the cursor somewhere
other than at the end.

> The original problem (worker/48788⁩) that is fixed by
> the above commit is not affected by this patch. I _hope_ there are
> no bad side effects.

I didn't find any.

References:
- [PATCH] fix completion of parameter names for ${<TAB> and ${(a)<TAB>
  - From: Jun. T

Messages sorted by: Reverse Date, Date, Thread, Author