Re: [PATCH] Do not define _POSIX_C_SOURCE when checking for sigset_t on Solaris

[Claes Nästén <pekdon@xxxxxxxxx>]

Excerpts from Oliver Kiddle's message of 2021-12-07 19:20:45 +0100:
> On 23 Nov, Claes Nästén wrote:
> > Trying to compile zsh on Solaris 10 fails for me right after
> > configuration due to misleading information in config.h
> >
> > The check for sigset_t fails, due to:
> 
> Thank you for isolating the cause of this and for the clear report.
> 
> The definition of _POSIX_C_SOURCE was added in 28989 (April 2011) for
> compatibility with musl libc.
> 
> I was thinking it'd be better to define it only for musl rather building
> up a list of exceptions such as Solaris. Trying a zsh build on a recent
> Alpine Linux system running within podman, it appears to return "yes"
> for the sigset_t test both with and without the #define. Perhaps musl
> has evolved for greater compatibility with glibc since 2011. I don't
> think we should be too concerned about the potential for someone to still
> be using old musl. Solaris 10, while quite a bit older than that if
> you don't count updates, is still relevant.
> 

Interesting, I would have thought musl wants to stay as compliant as
possible.

> 
> patch -R wouldn't work with 28989 because it was using the old
> AC_TRY_COMPILE macro at that time so I have attached a patch.
> 
> Oliver
> 

Great, works just as good as skipping on SunOS of course. :)