Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions
- X-seq: zsh-workers 49928
- From: Mikael Magnusson <mikachu@xxxxxxxxx>
- To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
- Cc: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: PATCH 2/2: [WIP] Efficient dedup for unsorted completions
- Date: Wed, 30 Mar 2022 20:33:24 +0200
- Archived-at: <https://zsh.org/workers/49928>
- In-reply-to: <CAH+w=7Y7hP90uwSg5a0056cBkOQSXw07p5GAVZ6giPR1vVqn=A@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20220326014030.2802-1-mikachu@gmail.com> <20220326014330.3050-1-mikachu@gmail.com> <CAH+w=7Y7hP90uwSg5a0056cBkOQSXw07p5GAVZ6giPR1vVqn=A@mail.gmail.com>
On 3/30/22, Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> On Fri, Mar 25, 2022 at 6:44 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>>
>> This implements my idea for sorting a temporary array and then using
>> that for deduplication.
>
> Minor nit, but after this patch I get:
>
> compcore.c: In function ‘makearray’:
> compcore.c:3289:26: warning: unused variable ‘i’ [-Wunused-variable]
> 3289 | int dup, i, del = 0;
> | ^
i is actually used in this patch, but not in the fixed version where I
forgot to remove the declaration, thanks.
--
Mikael Magnusson
Messages sorted by:
Reverse Date,
Date,
Thread,
Author