Re: Test release: 5.8.1.2-test

[Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>]

> On 10 April 2022 at 21:07 Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx> wrote:
> On Sat, 2022-04-09 at 15:07 -0500, dana wrote:
> > I've tagged 5.8.1.2-test (test release for the upcoming zsh 5.9) and
> > uploaded the artefacts to:
> > 
> >   https://sourceforge.net/projects/zsh/files/zsh-test/5.8.1.2-test/
> > 
> > If you have the time, please test and report any issues found.
> 
> Thanks very much for this, fine on my Ubuntu system.  I'll be able to
> try out on RedHat and Cygwin tomorrow.

Seems entirely clean on Ubuntu 16.04 and 18.04 and RedHat EL7.

Compiles on Cygwin but the test system is a bit sick on my laptop ---
not actually that unusual.  Unlikely to have time to look at this.

A couple of fixes will remove compilation warnings; it looks like
POSIX systems are pretty safe about signed characters these days
so Cygwin is about the only place where they still cause issues.

pws

diff --git a/Src/exec.c b/Src/exec.c
index 27d49e005..47753da48 100644
--- a/Src/exec.c
+++ b/Src/exec.c
@@ -561,7 +561,7 @@ zexecve(char *pth, char **argv, char **newenvp)
                         isbinary = 1;
                         hasletter = 0;
                         for (ptr = execvebuf; ptr < ptr2; ptr++) {
-                            if (islower(*ptr) || *ptr == '$' || *ptr == '`')
+                            if (islower(STOUC(*ptr)) || *ptr == '$' || *ptr == '`')
                                 hasletter = 1;
                             if (hasletter && *ptr == '\n') {
                                 isbinary = 0;
diff --git a/Src/prompt.c b/Src/prompt.c
index 738c7fc7a..092de63a4 100644
--- a/Src/prompt.c
+++ b/Src/prompt.c
@@ -1666,7 +1666,7 @@ match_colour(const char **teststrp, int is_fg, int colour)
 	tc = TCBGCOLOUR;
     }
     if (teststrp) {
-	if (**teststrp == '#' && isxdigit((*teststrp)[1])) {
+	if (**teststrp == '#' && isxdigit(STOUC((*teststrp)[1]))) {
 	    struct color_rgb color;
 	    char *end;
 	    zlong col = zstrtol(*teststrp+1, &end, 16);