Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: ZSH performance regression in 5.8.1.2-test

X-seq: zsh-workers 50091
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Jordan Patterson <jordanp@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: ZSH performance regression in 5.8.1.2-test
Date: Mon, 25 Apr 2022 11:56:59 -0700
Archived-at: <https://zsh.org/workers/50091>
In-reply-to: <CAHDOzW6wE2aP6-MMrBNAUYttzQwi2VC_OY7tJDwkQwrtp47zEQ@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHDOzW6wE2aP6-MMrBNAUYttzQwi2VC_OY7tJDwkQwrtp47zEQ@mail.gmail.com>

On Mon, Apr 25, 2022 at 11:26 AM Jordan Patterson <jordanp@xxxxxxxxx> wrote:
>
> This recent fix has led to a performance regression in zsh: 49792:
> Non-interative shell input is line buffered.

Hm.  If we use stdio for speed, we have memory management re-entrance
issues that can lead to a crash.

If we use direct read of more than one character at a time, we can't
enforce line buffering.

Is there a way we can detect the case where we need to line-buffer and
avoid it otherwise?

Follow-Ups:
- Re: ZSH performance regression in 5.8.1.2-test
  - From: Stephane Chazelas

References:
- ZSH performance regression in 5.8.1.2-test
  - From: Jordan Patterson

Messages sorted by: Reverse Date, Date, Thread, Author