Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH][RFC] Improve completion of Gradle tasks



On Fri 6 May 2022, at 21:57, Bart Schaefer wrote:
> Any objections to this sneaking into 5.9, despite .3-test already spun?

I don't know anything about Gradle, so i'm not sure if the way it handles
task completion is desirable. But i didn't see anything obviously wrong
with the patch, and it's not a critical component, so i don't object in
principle

I did note these pre-existing issues which might be fixed in a future
revision:

* _gradle_caching_policy is redefined every time the function executes

* possibly _arguments should have -s and/or -S?

* several of the options seem to be missing exclusion information

* none of the option descriptions use the conventional capitalisation,
  punctuation, or mood for completion functions

* there seems to be some confusion over whether short options that take
  arguments need + in the spec, and possibly the long options need =

* completion for -x just fails silently if there's no build file

dana




Messages sorted by: Reverse Date, Date, Thread, Author