Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
[PATCH 1/3] completion: make: don't build everything
- X-seq: zsh-workers 50435
- From: Felipe Contreras <felipe.contreras@xxxxxxxxx>
- To: zsh-workers@xxxxxxx
- Cc: Oliver Kiddle <okiddle@xxxxxxxxxxx>, Felipe Contreras <felipe.contreras@xxxxxxxxx>, Daniel Hahler <git@xxxxxxxxxx>
- Subject: [PATCH 1/3] completion: make: don't build everything
- Date: Fri, 29 Jul 2022 20:03:08 -0500
- Archived-at: <https://zsh.org/workers/50435>
- In-reply-to: <20220730010310.3383526-1-felipe.contreras@gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <20220730010310.3383526-1-felipe.contreras@gmail.com>
At least in GNU make 4.3 the -n option is *not* respected and
--always-make builds everything.
Instead use a fake .DEFAULT target the way bash-completion does.
This essentially reverts 597acaab4 (44722: _make: use --always-make
instead of .PHONY for GNU make, 2019-09-02).
Cc: Daniel Hahler <git@xxxxxxxxxx>
Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
---
Completion/Unix/Command/_make | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make
index ae91440f0..28c529a88 100644
--- a/Completion/Unix/Command/_make
+++ b/Completion/Unix/Command/_make
@@ -239,7 +239,7 @@ _make() {
if [[ $is_gnu == gnu ]]
then
if zstyle -t ":completion:${curcontext}:targets" call-command; then
- _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" --always-make 2> /dev/null)
+ _make-parseMakefile < <(_call_program targets "$words[1]" -nsp --no-print-directory -f "$file" .DEFAULT 2> /dev/null)
else
_make-parseMakefile < $file
fi
--
2.37.1.225.gfa48d685d2
Messages sorted by:
Reverse Date,
Date,
Thread,
Author