Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 3/3] completion: make: fix whitespaces



As this patch shows, _make has some indentation problems
(and also lots of other scripts have them).

> 2022/07/30 10:03, Felipe Contreras <felipe.contreras@xxxxxxxxx> write:
> 
> diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make

> @@ -12,35 +12,35 @@ _make-expandVars() {
> 
>     case $rest[2] in
>       ($)	    # '$$'. may not appear in target and variable's value
> -	front=$front\$\$
> -	rest=${rest[3,-1]}
> -	continue
> -	;;
> +        front=$front\$\$
> +        rest=${rest[3,-1]}
(snip)

# I didn't know that indent_style for scripts has changed from
# tab to space.

I have a vague memory of argument that it's not good to fix indent of
lines not related with the real fix because it makes 'git blame'
rather useless, and then someone wrote that 'git blame -w' can be used
in that case.

So, in general, is it better (or not) to apply this type of patch?




Messages sorted by: Reverse Date, Date, Thread, Author