Re: [PATCH] prompt: support generic non-visible regions

X-seq: zsh-workers 50455

From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>

To: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>

Cc: Felipe Contreras <felipe.contreras@xxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>, Oliver Kiddle <opk@xxxxxxx>, dana <dana@xxxxxxx>

Subject: Re: [PATCH] prompt: support generic non-visible regions

Date: Thu, 11 Aug 2022 10:21:21 -0500

Archived-at: <https://zsh.org/workers/50455>

In-reply-to: <CAN=4vMqHNZJ7BvCCNbD7-0nPr1CbN1ecHQVxSsaZQ1Ao13__jg@mail.gmail.com>

List-id: <zsh-workers.zsh.org>

References: <20220810115120.182853-1-felipe.contreras@gmail.com> <CAN=4vMqHNZJ7BvCCNbD7-0nPr1CbN1ecHQVxSsaZQ1Ao13__jg@mail.gmail.com>

On Thu, Aug 11, 2022, 9:38 AM Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx> wrote:

I like this patch but for a different reason. It closes the capability
gap in zsh prompts with and without prompt_percent.

I've been traveling this week without access to the source code so haven't otherwise commented on this, but:

1. Roman's point above is valid.

2. As previously mentioned by others, this is related to %{ %} rather than to %F, and should be implemented and documented as such. One cannot write $'\001red\002' (I presume) and it would not be generally useful in that context.

3. Escapes for ctrl-a and ctrl-b also work? Or this is explicitly looking for \001 \002 ? Any possible conflicts?

Reverse Date

Date

Thread

Author