Re: [PATCH] prompt: support generic non-visible regions

[Felipe Contreras <felipe.contreras@xxxxxxxxx>]

On Thu, Aug 11, 2022 at 1:32 PM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
> On 8/11/22, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote:

> > The commit message says:
> >
> > 1. We do readline $'\001\e[31m\002' as zsh '%F{red}'.
> >
> > This is true.
>
> The statement is true, but it's not what the commit message says, it says:
> "readline assumes anything between \001 (start of header) and \002 (start
> of text) is non-visible characters.
>
> In zsh we do this with `%F{color}`"

It's the same: what we do in zsh with `%F{color}`, we do in readline
with $'\001\e[31m\002'.

> I don't know why you are arguing about this, there's nothing bad about
> fixing an error in a commit message after someone points it out.

I don't believe it's an error. You are the one that is arguing it's an error.

Regardless of what you choose to call it, it will be changed. I don't
need you to believe it's correct, and you don't need me to believe
it's an error.

The end result is the same: it will change.

-- 
Felipe Contreras