Re: [RFC PATCH 0/3] Improve defaults

[Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>]

On Wed, Aug 24, 2022 at 2:50 PM Felipe Contreras
<felipe.contreras@xxxxxxxxx> wrote:
>
> On Wed, Aug 24, 2022 at 3:58 PM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> >
> > Side-effects upon existing uses of "fc -p" are not
> > considered,
>
> How are they not considered?

"fc -p" with no other arguments explicitly resets the variables to
their defaults.  The current default for SAVEHIST is zero, so having
that become nonzero is an issue.  Changing the default HISTSIZE is
less of a concern but still affects "fc -p".

> > nor are use cases involving SHARE_HISTORY, APPEND_HISTORY,
> > INC_APPEND_HISTORY, and HIST_SAVE_NO_DUPS,
>
> Once again, how are they not considered?

Simply that usually when any of those are set, which is not uncommon,
it makes much less sense to have equivalent values of SAVEHIST and
HISTSIZE.   As I said, that's probably a case where they're all being
set anyway, but these patches aren't helpful.