Re: [PATCH 1/2] Set SAVEHIST to $HISTSIZE by default

[Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx>]

Felipe Contreras wrote on Fri, Sep 02, 2022 at 04:29:30 -0500:
> On Fri, Sep 2, 2022 at 3:59 AM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
> > Felipe Contreras wrote on Tue, Aug 30, 2022 at 22:18:53 -0500:
> 
> > > If they are the same, this makes it clearer that they are the same.
> > >
> > > Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> > > ---
> > >  Etc/FAQ.yo                            | 2 +-
> > >  Functions/Newuser/zsh-newuser-install | 2 +-
> > >  2 files changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Etc/FAQ.yo b/Etc/FAQ.yo
> > > index 8c795685a..dd573767e 100644
> > > --- a/Etc/FAQ.yo
> > > +++ b/Etc/FAQ.yo
> > > @@ -1631,7 +1631,7 @@ label(321)
> > >    verb(
> > >      HISTSIZE=200
> > >      HISTFILE=~/.zsh_history
> > > -    SAVEHIST=200
> > > +    SAVEHIST=$HISTSIZE
> >
> > Personally, I'm not going to commit this since I find the increased
> > semantic precision / DRY compliance to be outweighed by the reduced
> > readability (both here and in the code below, but for different
> > reasons).
> 
> But you only need to read it *once* and forget about it forever (or at
> least as long as you keep the same history strategy).

You're summing over the wrong variable.  This isn't jrandom's zshrc;
this is the FAQ.  So, don't sum over how often jrandom will read this
passage of their zshrc, but over how often this part of the FAQ will be
read by existing and prospective users.

That's similar to how example code often uses --long-options in
preference to the equivalent one-letter short options, even though
regular users might not /know/ the long option equivalent to a short
option they use daily.

Daniel