Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET

X-seq: zsh-workers 50986
From: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>
To: Marlon Richert <marlon.richert@xxxxxxxxx>
Cc: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>, Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Thu, 17 Nov 2022 14:28:29 +0100
Archived-at: <https://zsh.org/workers/50986>
In-reply-to: <CAHLkEDuo112DieG6ur_M0giV4UXVTjKRLuzrpUchcoj6V_LEtA@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAHLkEDuuosi7udHsQ9uaBRcv5poEUU_i1iSRGgEXFbtBkzHQOQ@mail.gmail.com> <CAH+w=7ZpQ=GVCbOHfQwB5m98CdK6fcb2PTMxSRn8qijVCrX5kg@mail.gmail.com> <CAHLkEDuo112DieG6ur_M0giV4UXVTjKRLuzrpUchcoj6V_LEtA@mail.gmail.com>

On Thu, Nov 17, 2022 at 2:06 PM Marlon Richert <marlon.richert@xxxxxxxxx> wrote:
>
> It's not the "inverted meaning" here that is the bug. `zle -F` (with
> or without -w) just shouldn't ever change $LASTWIDGET in the first
> place. It breaks a lot of existing widget functions and there is no
> possible workaround.

Relevant: https://www.zsh.org/mla/workers/2019/msg00204.html

Especially this part:

> The same branch also adds -W option to zle widget command. This
> option instructs zle to keep LASTWIDGET unchanged.

This part of the patch wasn't applied and the code is long gone (I
didn't attach it to the email) but it's fairly straightforward to
implement.

Roman.

References:
- Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: Marlon Richert
- Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: Bart Schaefer
- Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
  - From: Marlon Richert

Messages sorted by: Reverse Date, Date, Thread, Author