Zsh Mailing List Archive
Messages sorted by: Reverse Date, Date, Thread, Author

Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements)



Bart Schaefer wrote on Wed, Nov 23, 2022 at 08:11:02 -0800:
> On Wed, Nov 23, 2022 at 1:44 AM Philippe Altherr
> <philippe.altherr@xxxxxxxxx> wrote:
> >> I'd also prefer to post all your patches at once because you attached
> >> them all to the same zsh-workers article.  Convention has been that a
> >> series of patches should be sent as a series of articles.

I don't think we should insist on this.

If someone has git-send-email(1) configured, sure, please send the
patches individually, and let email threading do its thing.  But if not…
I'd rather ask people to send one message with N attachments, numbered
as Philippe did in workers/51001, than ask people to send N separate
mails, in which case they might send nothing at all.

Besides, I'd like to enourage submitters to split their patches if in
doubt, since it's easier to combine patches ("42 + 43: foo") than to
split them ("42 (in part): foo").  So, I'd like to make it easier to
send multiple related diffs.  We can then commit them /en bloc/, or
squashed, or cherry-pick from them, as needed.

I did this myself a couple of times, e.g., in workers/48601.  Looking in
the archives, mhonarc (https://www.zsh.org/mla/workers/2021/msg00826.html)
doesn't render multiple text attachments sanely, but the official mbox
archives and public-inbox both do (https://inbox.vuxu.org/zsh-workers/20210416182141.GA15670@tarpaulin.shahaf.local2/T/#md006c516ad7f04f6d6225f213357839e4de03dcf).

Cheers,

Daniel

> > OK, then I will resend my patches in separate emails.
> 
> That's not necessary either, and I don't think any of the patches so
> far are controversial.
> 




Messages sorted by: Reverse Date, Date, Thread, Author