Re: [Patch] Fix ERR_RETURN behavior in and/or statements

X-seq: zsh-workers 51095

From: Philippe Altherr <philippe.altherr@xxxxxxxxx>

To: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>

Cc: Zsh hackers list <zsh-workers@xxxxxxx>, Lawrence Velázquez <larryv@xxxxxxx>

Subject: Re: [Patch] Fix ERR_RETURN behavior in and/or statements

Date: Sat, 3 Dec 2022 02:31:25 +0100

Archived-at: <https://zsh.org/workers/51095>

In-reply-to: <CAGdYchvvO4dAdY=7dT862uwy2AH5Tn9LTVd_BfdWy_5GV=+Kmw@mail.gmail.com>

List-id: <zsh-workers.zsh.org>

References: <CAGdYchvsHUNnjgW_wHEHcQVYguttj=BpiPq+zWyDHQeo3-KUGg@mail.gmail.com> <CAH+w=7bm5ZZtiyMKXOB8Jg4WYbvwR2RqPbTpUCqKBdbXb-iJUQ@mail.gmail.com> <CAGdYchvvO4dAdY=7dT862uwy2AH5Tn9LTVd_BfdWy_5GV=+Kmw@mail.gmail.com>

Hi Bart,

With my last patch (patch-08-use-or-assignments-to-set-noerrexit-bits), I think that I'm done with code changes. The best way to understand all of my changes might be to first apply all my 8 patches and have a look at all the places that deal with noerrexit (just grep for noerrexit in all files). The noerrexit logic is now quite a bit smaller and also more regular. For example all places that deal with conditions (if condition, while condition, left of &&/||, and right of !) now behave in very similar ways. Same for all compound commands. You can then have a look at the individual patches.

Philippe

On Sat, Nov 26, 2022 at 4:47 AM Philippe Altherr <philippe.altherr@xxxxxxxxx> wrote:

I'll take a look at all of this in a couple of days.

Sounds good

I just sent a 6th patch. With that, all the errexit issues I'm aware of are fixed.

I still have on my todo list to write a NEWS item that documents the changes/fixes. So there will be a 7th patch but that one will only touch the NEWS file.

There is one last thing that I don't understand in the errexit code, namely the NOERREXIT_UNTIL_EXEC bit used in execif. I will spend some time studying it in the next few days. Hopefully, I don't discover new issues :-)

Philippe

Reverse Date

Date

Thread

Author