Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Remove NOERREXIT_UNTIL_EXEC

X-seq: zsh-workers 51100
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Philippe Altherr <philippe.altherr@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>
Subject: Re: [PATCH] Remove NOERREXIT_UNTIL_EXEC
Date: Sat, 3 Dec 2022 21:28:54 -0800
Archived-at: <https://zsh.org/workers/51100>
In-reply-to: <CAGdYchsuZ7A+RYxrfSBsF0boZhd2ANYe85iVwg2XzUBEWg7NLg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAGdYchsuZ7A+RYxrfSBsF0boZhd2ANYe85iVwg2XzUBEWg7NLg@mail.gmail.com>

On Fri, Dec 2, 2022 at 4:31 PM Philippe Altherr
<philippe.altherr@xxxxxxxxx> wrote:
>
> The noerrexit NOERREXIT_UNTIL_EXEC bit is never set and can therefore be removed. In other words the patch only removes dead code.

That explains MY confusion over the meaning of NOERREXIT_UNTIL_EXEC
when you first asked about it:  The use for which it was originally
intended had gone away.

> One thing that distinguishes the NOERREXIT_UNTIL_EXEC bit from the other noerrexit bits is that it seems intended for the caller(s) of the function that sets it, while the other bits are intended for the callee(s). This is similar to today's this_noerrexit variable.

Moot point now, but I believe it was still intended for the callees --
the original bug being fixed involved error state propagating down
into for/select loops.

> QUESTION: Should NOERREXIT_SIGNAL's value be changed to 4 (from 8) since the value 4 is no longer used by NOERREXIT_UNTIL_EXEC?

I don't think that's necessary.

References:
- [PATCH] Remove NOERREXIT_UNTIL_EXEC
  - From: Philippe Altherr

Messages sorted by: Reverse Date, Date, Thread, Author