Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] NEWS item about the ERR_EXIT fixes
- X-seq: zsh-workers 51164
- From: Lawrence Velázquez <larryv@xxxxxxx>
- To: "Philippe Altherr" <philippe.altherr@xxxxxxxxx>
- Cc: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
- Subject: Re: [PATCH] NEWS item about the ERR_EXIT fixes
- Date: Sat, 10 Dec 2022 02:35:34 -0500
- Archived-at: <https://zsh.org/workers/51164>
- Feedback-id: iaa214773:Fastmail
- In-reply-to: <CAGdYchuG_D42UeDS3ernSfPsaYCarRxuZnBha2Tq=3OJQrdJvg@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAGdYchux2TcXzp0jUZZfpGMZZT8oe9zB-YkgAs8JepxpaedESw@mail.gmail.com> <CAH+w=7aH6STxZv5AE9J-FZXRRvd7qu+2jqMJ0hMW0Lj__u2Z3Q@mail.gmail.com> <46fcb939-0ed9-4b51-959d-67339181e3e3@app.fastmail.com> <CAGdYchuG_D42UeDS3ernSfPsaYCarRxuZnBha2Tq=3OJQrdJvg@mail.gmail.com>
On Fri, Dec 9, 2022, at 4:30 AM, Philippe Altherr wrote:
>> + - Function calls, anonymous functions, and the `eval`, `.`, and
>> + `source` commands no longer propagate ERR_EXIT suppression.
>
> This kind of suggests that these constructs always propagated the
> suppression, which isn't the case, but the exact circumstances look too
> complex to explain. Maybe replace "no longer" with "now never".
What were the circumstances under which they previously propagated
suppression?
>> +The ERR_RETURN option is now suppressed when a function containing
>> +a compound sublist (`&&` or `||`) is called from within another compound
>> +sublist.
>
> I find this a bit cryptic. It may also give the wrong impression that
> functions containing a compound sublist are a special case. And
> finally, the same is true for functions called in if/while conditions.
I admit that I don't fully understand what this commit did, so I
more or less copied the entry Bart added to ChangeLog:
* Philippe Altherr: 51071: Src/exec.c, Test/C03traps.ztst: fix
ERR_RETURN when a function using && / || is called within another
statement using && / ||
That's not accurate either, then?
--
vq
Messages sorted by:
Reverse Date,
Date,
Thread,
Author