Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: EXIT trap not executed on error

X-seq: zsh-workers 51217
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Philippe Altherr <philippe.altherr@xxxxxxxxx>
Cc: Zsh hackers list <zsh-workers@xxxxxxx>, Martijn Dekker <martijn@xxxxxxxx>
Subject: Re: EXIT trap not executed on error
Date: Wed, 14 Dec 2022 22:40:03 -0800
Archived-at: <https://zsh.org/workers/51217>
In-reply-to: <CAGdYchuroqX0=owcipX0ChvxxK-ASVY1PO7H_duVP=DcGMindA@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <1939278e-89c4-812d-5dea-e836568dc100@inlv.org> <CAH+w=7ZBiyGz20aY1_v0Yy9Cvcb1rrdZC6OjQ1u39iG+TECArw@mail.gmail.com> <CAH+w=7ZTE=Y2gznhxfAByTGHuWriu5aiCev_8Fas-UOf1gWboQ@mail.gmail.com> <CAGdYchuroqX0=owcipX0ChvxxK-ASVY1PO7H_duVP=DcGMindA@mail.gmail.com>

On Wed, Dec 14, 2022 at 12:35 AM Philippe Altherr
<philippe.altherr@xxxxxxxxx> wrote:
>
> I had a look at the errflag logic and admittedly I don't understand everything/much. However I noticed that other places that restore the errflag preserve the ERRFLAG_INT bit.

IMO that's irrelevant ... no trap will run when errflag is set, and in
theory at least the exit trap is the last thing we're going to do, so
remembering that we got an interrupt during the trap doesn't mean
much.  zexit() actually goes so far as to clear errflag twice and to
clear intrap as well the second time.  I'm actually pretty sure saving
and restoring errflag is not needed at all.

> I also wondered whether signals.c/dotraps would be a better place for the new logic.

I considered that, but saw dotraps being re-entered while stepping
through things with the debugger, so I thought it better to stay with
doing changes in the caller.

References:
- Re: EXIT trap not executed on error
  - From: Bart Schaefer
- Re: EXIT trap not executed on error
  - From: Bart Schaefer
- Re: EXIT trap not executed on error
  - From: Philippe Altherr

Messages sorted by: Reverse Date, Date, Thread, Author