Re: [PATCH 1/1] Update gnu make completion for version 4.4

["Daniel Shahaf" <d.s@xxxxxxxxxxxxxxxxxx>]

Shohei Yoshida wrote on Fri, 20 Jan 2023 02:53 +00:00:
> On Thu, Jan 19, 2023 at 10:56 PM Daniel Shahaf <d.s@xxxxxxxxxxxxxxxxxx> wrote:
>> Shohei YOSHIDA wrote on Thu, Jan 19, 2023 at 10:57:24 +0900:
>> > +++ b/Completion/Unix/Command/_make
>> > @@ -165,6 +165,7 @@ _make() {
>> >    then
>> >      incl="(-|)include"
>> >      option_specs=(
>> > +      '(-b -m)'{-b,-m}'[ignored for compatibility]'
>>
>> Should we add an «!» to this optspec, so these two options aren't shown
>> in the output?
>
> Yes. I missed it, sorry. By the way, -b and -m options are ignored by
> gnu make and make no sense.
> So I removed it from the option list.

Sounds good to me.

>> > @@ -185,17 +187,18 @@ _make() {
>> >        '(-p --print-data-base)'{-p,--print-data-base}'[print makes internal database]'
>>
>> Preëxisting issue: we should add the missing apostrophe.
>
> I fixed it.

Thanks a lot.

> Attachments:
> * 0001-Update-gnu-make-completion-for-version-4.4.patch

Pushed with a minor tweak (described the format of "seed" in the optarg
of --shuffle).

Thanks for the patch,

Daniel