Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Named reference typos & misc.
- X-seq: zsh-workers 51433
- From: Peter Stephenson <p.w.stephenson@xxxxxxxxxxxx>
- To: Zsh hackers list <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] Named reference typos & misc.
- Date: Tue, 14 Feb 2023 14:46:59 +0000 (GMT)
- Archived-at: <https://zsh.org/workers/51433>
- Importance: Normal
- In-reply-to: <CAH+w=7YRxyV6sj4eobpgo3aEgw3MOZj6jJ9bhi+acJn=ywbVAA@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAH+w=7YRxyV6sj4eobpgo3aEgw3MOZj6jJ9bhi+acJn=ywbVAA@mail.gmail.com>
> On 14/02/2023 02:08 Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
> More stuff helpfully noticed by Oliver; the last patch unintentionally
> regressed one valid assignment usage, typeset +m and $parameters
> returned (different) incorrect results for named references, and
> testing for typeset +m revealed a segfault with typeset -p.
I need the following to make the tests pass --- else no error message.
It's possible I'm missing something, I'm not following every detail
here but it looks like everything is committed up to date so probably
worth mentioning. I won't commit this since Bart will know if this
reflects a more fundamental problem.
diff --git a/Test/K01nameref.ztst b/Test/K01nameref.ztst
index d240e49..38a5fbd 100644
--- a/Test/K01nameref.ztst
+++ b/Test/K01nameref.ztst
@@ -651,6 +651,7 @@ F:Same test, should part 5 output look like this?
>typeset -n ref=two
>typeset -n ref=var
+ unsetopt typeset_to_unset
unset -n ref
unset one
typeset -n ref
pws
Messages sorted by:
Reverse Date,
Date,
Thread,
Author