Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 2/3] Make dynamic dir completion easier to implement

X-seq: zsh-workers 51742
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Re: [PATCH 2/3] Make dynamic dir completion easier to implement
Date: Sat, 13 May 2023 10:30:52 -0700
Archived-at: <https://zsh.org/workers/51742>
In-reply-to: <CAH+w=7b5SEsgWi84xb0bUzEMB7y=uRV8YuiE8y08JjqAQCNZvA@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <CAH+w=7aWEesO_hN+eUCj9VCJ+soUvXqSSNRAAPSY-JoCZvcWcQ@mail.gmail.com> <20230505114154.76547-2-marlonrichert@users.noreply.github.com> <CAH+w=7b5SEsgWi84xb0bUzEMB7y=uRV8YuiE8y08JjqAQCNZvA@mail.gmail.com>

On Sat, May 6, 2023 at 10:28 AM Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx> wrote:
>
> Not necessarily asking Marlon to do this, but if this patch is going
> to be included we need to repair these two functions:
>
> Functions/Chpwd/zsh_directory_name_cdr
> Functions/Chpwd/zsh_directory_name_generic

Attempting to extrapolate from Marlon's edits to the doc example, I
think the only part of these that really needs to change is the "if
completion" branch.  However, I'm not a user of the "cdr" functions so
I'm not sure what to do with the former, or if the "Can't complete in
the middle" warning still applies in the latter (and if it does, is
that a problem with Marlon's patch?); nor if the explanatory text
passed to _describe in either function has to move somewhere.

References:
- Re: Patch 1/3: Fix prefix insertion logic
  - From: Bart Schaefer
- [PATCH 2/3] Make dynamic dir completion easier to implement
  - From: Marlon Richert
- Re: [PATCH 2/3] Make dynamic dir completion easier to implement
  - From: Bart Schaefer

Messages sorted by: Reverse Date, Date, Thread, Author