Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
- X-seq: zsh-workers 51948
- From: dana <dana@xxxxxxx>
- To: "Bart Schaefer" <schaefer@xxxxxxxxxxxxxxxx>
- Cc: "Zsh hackers list" <zsh-workers@xxxxxxx>, "Peter Stephenson" <p.w.stephenson@xxxxxxxxxxxx>
- Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
- Date: Mon, 17 Jul 2023 10:52:01 -0500
- Archived-at: <https://zsh.org/workers/51948>
- Feedback-id: i9be146f9:Fastmail
- In-reply-to: <CAH+w=7a04Xv7sGMBuDmBTY2Vw8Jb9q=OMgg6mRs-E8ThQzCwTw@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <CAHLkEDuuosi7udHsQ9uaBRcv5poEUU_i1iSRGgEXFbtBkzHQOQ@mail.gmail.com> <CAH+w=7Y4jT5kNNSkCXZMcFg7kzTew3LDfLgq8zPkr30D5=QSsA@mail.gmail.com> <422608219.9324398.1673947338127@mail.virginmedia.com> <CAH+w=7a4x+BDM=cxAtu5AsryF0Do9=nO5P+11uR2U2M3VcYeYQ@mail.gmail.com> <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com> <CAH+w=7a04Xv7sGMBuDmBTY2Vw8Jb9q=OMgg6mRs-E8ThQzCwTw@mail.gmail.com>
On Mon 17 Jul 2023, at 10:17, Bart Schaefer wrote:
> The patch from the start of this thread has never been committed, so
> is not directly related. That is, if the Thingy is invalid, it's not
> $LASTWIDGET that's making the bad reference here, so fixing
> save/restore there probably will not resolve the problem.
Sorry, i'm not very familiar with the LASTWIDGET mechanism, but by the patch
at the start of this thread you mean workers/51310, right? It was committed
as f93ad02b94bd
I should have mentioned that i did a (manual) bisect to confirm that that is
when the problem started for me; the poster in workers/51673 found the same,
with what sounds like a very similar configuration (though they didn't
provide any other details). I can't get the problem to occur on a build off
the preceding commit or on the 5.9 release
I did examine the functions the trace references before; the
_zsh_highlight_widget_orig... one simply calls _zsh_highlight_call_widget,
and that one calls zle before calling another highlight function (but the
crash happens in zle so it's not getting to that). The autosuggest ones are a
little more elaborate. I can get back to it later
dana
Messages sorted by:
Reverse Date,
Date,
Thread,
Author