Re: [PATCH] completion libvirt: edit action is always allowed

["Jun. T" <takimoto-j@xxxxxxxxxxxxxxxxx>]

> 2023/08/24 6:01、sergio <sergio@xxxxxxxxxxxxx>のメール:
> 
> On 22/08/2023 09:54, Jun T wrote:
> 
>> I'm not familiar with virsh, but if --all is the correct option
>> to use then we can just remove dom_opts[edit] since the array
>> is used as ${dom_opts[$cmd]:-"--all"}.
> 
> No, no. When I do `virsh shutdown` or `virsh console` I would like to only active guests (that are shown with `virsh list`). `--all` shows all, including powered off.

dom_opts has entries for shutdown and cosole subcommands:
dom_opt[shutdown]='--state-running'
dom_opt[console]=' '

--all is used if dom_opt[subcmd] does not exists.
If you want to use -all for the subcommand 'edit', then
you can just remove dom_opt[edit].

Could you please confirm that your patch and mine give the
same list of domains for edit subcommand?