Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
github PR to "Add command to improve robustness"
- X-seq: zsh-workers 52164
- From: Oliver Kiddle <opk@xxxxxxx>
- To: Zsh workers <zsh-workers@xxxxxxx>
- Subject: github PR to "Add command to improve robustness"
- Date: Wed, 20 Sep 2023 19:20:03 +0200
- Archived-at: <https://zsh.org/workers/52164>
- List-id: <zsh-workers.zsh.org>
PR #101 adds "command" in several command substitutions in
_find_net_interfaces:
https://github.com/zsh-users/zsh/pull/101/files
I would guess that the cause of the "bug" is function wrappers being
defined which wrap ifconfig and ip to apply colouring to their output.
There are a few random other cases where command is used as a
pre-command modifier in the completions like this. I'm not keen on
applying this selectively in one or two instances. And even less keen
on adding it everywhere. Shouldn't it be _call_program's job to apply
this? Though I've no idea how that can cope with pipelines. Or with
the few cases where we use it to run builtins. I've never been keen on
_call_program's use of eval - if the command comes from a style then
fair enough but for the predefined one it mostly isn't helping anything.
Any ideas?
Or should we just tell them to test something like [[ -t 1 ]] if they
insist on writing wrappers for system utilities that add colour.
Oliver
Messages sorted by:
Reverse Date,
Date,
Thread,
Author