Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH] Fix gradlew completion

X-seq: zsh-workers 52175
From: Oliver Kiddle <opk@xxxxxxx>
To: Shohei YOSHIDA <syohex@xxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: [PATCH] Fix gradlew completion
Date: Sat, 23 Sep 2023 01:36:55 +0200
Archived-at: <https://zsh.org/workers/52175>
In-reply-to: <20230922025003.33716-1-syohex@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20230922025003.33716-1-syohex@gmail.com>

Shohei YOSHIDA wrote:
> gradlew is not usually in the PATH so the command to retrieve tasks would fail
> due to 'command not found'. So it should execute './gradlew' instead of 'gradle'
> if service is gradlew and there is an executable file './gradlew' in current
> directory

Trying to run $service from a completion function is nearly always
wrong because any path prefix has first been stripped. Rather than
trying to handle the current directory, it is probably better to just
use $words[1] instead. Then if someone completes after ../gradlew or
/somewhere/else/gradlew then it will use the location they specified.
If there is no gradlew there, they're going to have other problems when
they try to execute it anyway.

Oliver

Follow-Ups:
- Re: [PATCH] Fix gradlew completion
  - From: Shohei Yoshida

References:
- [PATCH] Fix gradlew completion
  - From: Shohei YOSHIDA

Messages sorted by: Reverse Date, Date, Thread, Author