Re: PATCH: pcre callouts

[Oliver Kiddle <opk@xxxxxxx>]

Bart Schaefer wrote:
> I didn't try applying the previous patch, but now that this one has
> been pushed to sourceforge:

I'm less sure on whether to push the later one for setting a scope.
And perhaps whether to add a -f option to pcre_match for a fixed callout
function that can avoid shell evaluation and handle numeric callouts.

> pcre.c: In function ‘pcre_callout’:
> pcre.c:132:44: error: parameter name omitted
>   132 | pcre_callout(pcre2_callout_block_8 *block, void *)
>       |                                            ^~~~~~

Sorry, I think the following form should be right.

Oliver

diff --git a/Src/Modules/pcre.c b/Src/Modules/pcre.c
index e6b59831f..e48ae3ae5 100644
--- a/Src/Modules/pcre.c
+++ b/Src/Modules/pcre.c
@@ -129,7 +129,7 @@ bin_pcre_study(char *nam, UNUSED(char **args), UNUSED(Options ops), UNUSED(int f
 }
 
 static int
-pcre_callout(pcre2_callout_block_8 *block, void *)
+pcre_callout(pcre2_callout_block_8 *block, UNUSED(void *callout_data))
 {
     Eprog prog;
     int ret=0;