Zsh Mailing List Archive
Messages sorted by:
Reverse Date,
Date,
Thread,
Author
Re: [PATCH] cd: Append 2nd argument to CWD if 1st is empty
- X-seq: zsh-workers 52351
- From: Julian Prein <druckdev@xxxxxxxxxxxxxx>
- To: Mikael Magnusson <mikachu@xxxxxxxxx>
- Cc: Roman Perepelitsa <roman.perepelitsa@xxxxxxxxx>, "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
- Subject: Re: [PATCH] cd: Append 2nd argument to CWD if 1st is empty
- Date: Fri, 01 Dec 2023 15:05:42 +0000
- Archived-at: <https://zsh.org/workers/52351>
- Feedback-id: 54984029:user:proton
- In-reply-to: <CAHYJk3Ru9dN0URPg-bipUP1RV7cw=vJ4xUyh0ksHxkrhE2wh=g@mail.gmail.com>
- List-id: <zsh-workers.zsh.org>
- References: <IZyXHgegIr8a18HfmW1WE7S2UYguBiREgTX0rv0u4WXrJO92IhaP9PVRDvoiEan85dZZL6Gvi4dQeSAgTAiFWitlFReFgse2lMJvCDcsbZM=@protonmail.com> <CAN=4vMrnmJuZ75bgcT94tah8cUDEG6V2fZh=U_u50wdG=TsPxg@mail.gmail.com> <3uINOrbo4IXmuxTPyOMY6U_gv4-qULOThBv5Hd01KcO76FK9AvEFOOIo02fy5VQBIrudqP7rz__wEo1FOG2X2cMLkJzV1wp-1fYkCKYID_8=@protonmail.com> <CAHYJk3Ru9dN0URPg-bipUP1RV7cw=vJ4xUyh0ksHxkrhE2wh=g@mail.gmail.com>
On Friday, December 1st, 2023 at 14:51, Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> I'm not opposed to the patch, but you could just cd $PWD-branchname in
> this case.
True. For me personally though, typing $PWD always feels a bit clunky and
unergonomic as I have to hold shift constantly.
> It's also easy to get the desired functionality with a
> wrapper function (admittedly slightly less easy if you also want to
> handle edge cases like cd -L '' foo but you probably don't):
> cd() {
> if [[ $# == 2 ]] && [[ $1 = "" ]]; then
> builtin cd $PWD$2
> else
> builtin cd "$@"
> fi
> }
Yes, that is probably what I'll do, if the patch gets rejected. But I am not a
big fan of wrapper functions that have to parse arguments and tend to not want
to break existing functionality through them.
Thanks,
Julian
Attachment:
signature.asc
Description: OpenPGP digital signature
Messages sorted by:
Reverse Date,
Date,
Thread,
Author