Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: PATCH: Improve quote handling in _ant completion

X-seq: zsh-workers 52362
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: Mikael Magnusson <mikachu@xxxxxxxxx>
Cc: German Riano <griano@xxxxxxxxx>, "zsh-workers@xxxxxxx" <zsh-workers@xxxxxxx>
Subject: Re: PATCH: Improve quote handling in _ant completion
Date: Sat, 2 Dec 2023 15:31:03 -0800
Archived-at: <https://zsh.org/workers/52362>
In-reply-to: <CAHYJk3Se5aCcFqKuk+fOpTF+tE5FeimQUvK3MAirz2fehaZGtw@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> <CAH+w=7YUfXaHAL=PR1tGB4J6gy7HDAbfwnPtiV4wzCpPC6ZFdw@mail.gmail.com> <CAHYJk3Se5aCcFqKuk+fOpTF+tE5FeimQUvK3MAirz2fehaZGtw@mail.gmail.com>

On Wed, Nov 29, 2023 at 11:56 AM Mikael Magnusson <mikachu@xxxxxxxxx> wrote:
>
> >> Also I am proposing to shield 'find_targets' with '((
> >> $#functions[find_targets] )) ||' so that users can easily override the
> >> function.
> >
> > No particular objection to this, though I wonder if it should be tied
> > to the "targets" style and _call_program (Oliver?)
>
> It should probably also be renamed to _ant_find_targets or something
> similar, it's very unexpected that a completer pollutes the main
> function namespace.

I've lost track of whether Oliver originally wrote this completer or
merely committed it, but I'm going to leave this bit unchanged for him
to weigh in.

Follow-Ups:
- Re: PATCH: Improve quote handling in _ant completion
  - From: Oliver Kiddle

References:
- PATCH: Improve quote handling in _ant completion
  - From: German Riano
- Re: PATCH: Improve quote handling in _ant completion
  - From: Bart Schaefer
- Re: PATCH: Improve quote handling in _ant completion
  - From: Mikael Magnusson

Messages sorted by: Reverse Date, Date, Thread, Author