Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH 0/2] incompatible-poiner-types bug fixes

X-seq: zsh-workers 52406
From: Oliver Kiddle <opk@xxxxxxx>
To: Nicholas Vinson <nvinson234@xxxxxxxxx>
Cc: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>, zsh-workers@xxxxxxx
Subject: Re: [PATCH 0/2] incompatible-poiner-types bug fixes
Date: Tue, 12 Dec 2023 00:55:00 +0100
Archived-at: <https://zsh.org/workers/52406>
In-reply-to: <3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com>
List-id: <zsh-workers.zsh.org>
References: <cover.1702244381.git.nvinson234@gmail.com> <CAH+w=7aYcRqLhyNFMkmXZfxkLThtxPqYBt0qxXamhoOa8FyOWA@mail.gmail.com> <3a2be586-89ce-4eac-b889-2a6cd8a38d72@gmail.com>

Nicholas Vinson wrote:
> If configure incorrectly decides (or is incorrectly told) that boolcodes 
> or numcodes do not exist, you end up with a naming conflict at 
> compile-time. This happened while I was testing my changes. I suspect, 

It may be for the best that we get errors if configure has got things
wrong.

> Moreover, these changes align the handling of all three variables, 
> boolcodes, numcodes, strcodes, in a type-safe and name-safe manner.

If adding const makes the code align with ncurses then that could be
useful. But the #defines seem ugly and unnecessary.

Oliver

References:
- [PATCH 0/2] incompatible-poiner-types bug fixes
  - From: Nicholas Vinson
- Re: [PATCH 0/2] incompatible-poiner-types bug fixes
  - From: Bart Schaefer
- Re: [PATCH 0/2] incompatible-poiner-types bug fixes
  - From: Nicholas Vinson

Messages sorted by: Reverse Date, Date, Thread, Author