Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Re: [PATCH v2] string.c: remove use of strcat() after strlen()

X-seq: zsh-workers 52436
From: Bart Schaefer <schaefer@xxxxxxxxxxxxxxxx>
To: James <tirtajames45@xxxxxxxxx>
Cc: zsh-workers@xxxxxxx
Subject: Re: [PATCH v2] string.c: remove use of strcat() after strlen()
Date: Sat, 30 Dec 2023 21:20:29 -0800
Archived-at: <https://zsh.org/workers/52436>
In-reply-to: <CANDqPp1yQ_r_6QSGp27mw7_5Nhc-XHowbe-TyOqnU8jb1KLDzg@mail.gmail.com>
List-id: <zsh-workers.zsh.org>
References: <20231226060159.182340-1-tirtajames45@gmail.com> <CAH+w=7a9xTJLPgagPmHE15Jy1vXDmDKKmuUi-JUYSqivnc-q8A@mail.gmail.com> <CANDqPp1yQ_r_6QSGp27mw7_5Nhc-XHowbe-TyOqnU8jb1KLDzg@mail.gmail.com>

On Sat, Dec 30, 2023 at 9:10 PM James <tirtajames45@xxxxxxxxx> wrote:
>
> Since we are already calling strlen() beforehand to know the size of allocation, we can just memcpy()

Fair enough, but the function you've optimized is called so seldom
that this is not going to have a meaningful effect on performance.

> I'm using a MEMPCPY macro because I don't know how zsh handles using GNU/POSIX extensions.

Please explain why that matters?  The macro is used exactly once after
being declared and there are no preprocesor conditionals around it.

References:
- [PATCH v2] string.c: remove use of strcat() after strlen()
  - From: James Tirta Halim
- Re: [PATCH v2] string.c: remove use of strcat() after strlen()
  - From: Bart Schaefer
- Re: [PATCH v2] string.c: remove use of strcat() after strlen()
  - From: James

Messages sorted by: Reverse Date, Date, Thread, Author