Zsh Mailing List Archive Messages sorted by: Reverse Date, Date, Thread, Author

Regression: 'read -s' does not disable echo

X-seq: zsh-workers 52458
From: Phil Pennock <zsh-workers+phil.pennock@xxxxxxxxxxxx>
To: zsh-workers@xxxxxxx
Subject: Regression: 'read -s' does not disable echo
Date: Tue, 2 Jan 2024 10:25:53 -0500
Archived-at: <https://zsh.org/workers/52458>
List-id: <zsh-workers.zsh.org>
Mail-followup-to: zsh-workers@xxxxxxx
Openpgp: url=https://www.security.spodhuis.org/PGP/keys/keys-2013rsa-2020cv25519.asc

Folks, there's a regression on git mainline such that `read -s` does not
suppress terminal echo.

I recompiled yesterday, for the first time since ... I think last March.
I don't have the complete patch-level I was at before, sorry.  I'm now
at commit `a528af5c5` (or one after, for a local patch).

Running:

    read -s -r 'SUPER_SECRET?Enter your super secret: '

should read into $SUPER_SECRET without terminal echo.  The '-r' is not
needed to reproduce, but included to show that yes, I'm considering
that.

Reproduces when started with `zsh -f`.

~% zsh -f
fullerene% read -s -r 'SUPER_SECRET?Enter your super secret: '
Enter your super secret: wobble
fullerene% echo $ZSH_VERSION $ZSH_PATCHLEVEL
5.9.0.1-dev pdp/phil-local-patches/zsh-5.9-341-gb6bd6cc0c

Environment is Linux (Ubuntu 20.04, amd64/x86_64) in gnome-terminal,
reproduces in xterm too.

-Phil

Follow-Ups:
- Re: Regression: 'read -s' does not disable echo
  - From: Peter Stephenson

Messages sorted by: Reverse Date, Date, Thread, Author