Re: [PATCH 1/1] zsh/random module

[Clinton Bunch <cdb_zsh@xxxxxxxxxxx>]

On 3/25/2024 19:42, Clinton Bunch wrote:
> On 3/25/2024 18:59, Oliver Kiddle wrote:
> > Clinton Bunch wrote:
> > > +startitem()
> > > +vindex(SRANDOM)
> > > +item(tt(SRANDOM)) (
> > > +A random positive 32-bit integer between 0 and 4,294,967,295.  This 
> > > parameter
> > > +is read-only.
> > > +)
> > It'd be useful to spell-out exactly what the "S" in the name stands for.
> I'm not honestly sure what it stands for, I used it for compatibility 
> with bash.  Possibly 'system'?

Does this sound better:

A random positive 32-bit integer between 0 and 4,294,967,295. This parameter
is read-only. The name was chosen for compatibility with Bash and to
distinguish it from tt(RANDOM) which has a documented repeatable behavior.

> > > +static int
> > > +ztr_to_hex(char *out, size_t outlen, uint8_t *input, size_t inlen)
> > Nothing calls this function does it? I'm guessing this is leftover from
> > the builtin in earlier patches.
> >
> > Oliver
> I meant to delete that before posting.  I hadn't done so prior because 
> I haven't given up entirely on implementing those builtins at a later 
> date.